ayushtkn commented on PR #4621: URL: https://github.com/apache/hive/pull/4621#issuecomment-1712048891
Passing by: @rtrivedi12 / @saihemanth-cloudera Isn't this change an incompatible change? Earlier I could have configured 1gb or 512mb, I think now these values aren't valid since we aren't using getSizeVar(). So, anybody following that approach will get exceptions now? Secondly, Why did we not just changed the default value, why we changed the type, we could have put ```2147483647b``` as the value? Thirdly, Why it is long here, not getIntVar & setIntVar? is it just because of SizeValidator? The value greater than Int max will anyway throw exception, so why getLong and type case to int? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
