abstractdog commented on code in PR #4630:
URL: https://github.com/apache/hive/pull/4630#discussion_r1321540311
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java:
##########
@@ -197,6 +200,10 @@ public void close() throws Exception {
for (Map.Entry<String, Metric> metric :
metricRegistry.getMetrics().entrySet()) {
metricRegistry.remove(metric.getKey());
}
+ if (hadoopMetricsStarted) {
+ DefaultMetricsSystem.shutdown();
Review Comment:
I guess the DefaultMetricsSystem.shutdown() is idempotent, so we can call
this anytime, however, it prints an ugly exception to the logs from
MetricsSystemImpl.stop(), so even if I don't like this started boolean
flagging, it's the way to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
