ayushtkn commented on code in PR #4673:
URL: https://github.com/apache/hive/pull/4673#discussion_r1321705921
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1537,6 +1544,15 @@ public boolean
shouldOverwrite(org.apache.hadoop.hive.ql.metadata.Table mTable,
return COPY_ON_WRITE.equalsIgnoreCase(mode);
}
+ @Override
+ public void addResourcesForCreateTable(Map<String, String> tblProps,
HiveConf hiveConf) {
+ String metadataLocation =
tblProps.get(BaseMetastoreTableOperations.METADATA_LOCATION_PROP);
+ if (StringUtils.isNotEmpty(metadataLocation)) {
Review Comment:
it would be empty in general unless someone provides the the metadata
location as part of the create command. like in normal create command it would
be empty
create table ice (schema) stored by iceberg;
it would be empty here.
create table ice TBLPROPERTIES(metadata-location='') stored by iceberg;
we handle this case, & if it is provided we do the logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
