rkirtir opened a new pull request, #4682: URL: https://github.com/apache/hive/pull/4682
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute 2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary 3. Ensure you have added or run the appropriate tests for your PR: 4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'. 5. Be sure to keep the PR description updated to reflect all changes. 6. Please write your PR title to summarize what this PR proposes. 7. If possible, provide a concise example to reproduce the issue for a faster review. --> ### What changes were proposed in this pull request? Original PR https://github.com/apache/hive/pull/4497 was merged to stream but had to revert because of mockito changes. Rerasing this PR after fixing mockito change https://issues.apache.org/jira/browse/HIVE-23680 TestDbNotificationListener was flakey as well as broken . As a part of fix, There are nowtotal 3 test classes based on broken tests in TestDbNotificationListener TestDbNotificationListener Fix of existing tests which includes nontransactional events TestDbNotificationCleanup This class includes tests which asserts cleanup of events based on TTL configurations TestTransactionalDbNotificationListner This class included tests with transactional event. This needs extra HMS test setup and acid properties setting. ### Why are the changes needed? TestDbNotificationListener is broken http://34.66.156.144:8080/job/hive-precommit/job/master/35/testReport/ http://130.211.9.232/job/hive-flaky-check/24/ ### Does this PR introduce _any_ user-facing change? NO ### Is the change a dependency upgrade? NO ### How was this patch tested? http://ci.hive.apache.org/job/hive-flaky-check/722/ http://ci.hive.apache.org/job/hive-flaky-check/721/ http://ci.hive.apache.org/job/hive-flaky-check/720/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org