deniskuzZ commented on code in PR #4633:
URL: https://github.com/apache/hive/pull/4633#discussion_r1322553403
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constraint/ConstraintsUtils.java:
##########
@@ -282,6 +298,48 @@ private static List<ConstraintInfo>
generateConstraintInfos(ASTNode child, List<
return constraintInfos;
}
+ static class ConstraintExpressionContext implements NodeProcessorCtx {
+ private UnparseTranslator unparseTranslator;
+
+ public ConstraintExpressionContext(UnparseTranslator unparseTranslator) {
+ this.unparseTranslator = unparseTranslator;
+ }
+
+ public UnparseTranslator getUnparseTranslator() {
+ return unparseTranslator;
+ }
+ }
+
+ private static UnparseTranslator
collectUnescapeIdentifierTranslations(ASTNode node)
Review Comment:
should we mark inner static classes as final as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
