zabetak commented on PR #4675: URL: https://github.com/apache/hive/pull/4675#issuecomment-1715397756
> It looks good to me. My only comment is optional - usually I like having at least a minimal qtest that tests the HiveConf combinations since it clearly demonstrates that everything is working end to end. In this case it might be overkill since you have created unit tests and it might be duplicating test coverage. You never know what may break in the future so I added an end-to-end test as part of https://github.com/apache/hive/pull/4675/commits/fad26dedbf1222a7ae51b8618e0ec770aa94f874. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
