ramesh0201 commented on code in PR #4692:
URL: https://github.com/apache/hive/pull/4692#discussion_r1329625166


##########
accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/AccumuloSerDe.java:
##########
@@ -54,6 +54,11 @@ public class AccumuloSerDe extends AbstractSerDe {
 
   private static final Logger log = 
LoggerFactory.getLogger(AccumuloSerDe.class);
 
+  @Override
+  public Logger getClassLogger() {
+    return log;
+  }
+

Review Comment:
   How can I avoid this pattern and still achieve the instantiated class name 
in the log for debugging/reading purposes. Like I see below in the log:
   **orc.OrcSerde: SerDe initialized: [Optional[Configuration:.....**
   If I do not override method to return this fields and rather use the parent 
class logger then I will end up something like below:
   **serde2.AbstractSerDe: SerDe initialized: [Optional[Configuration:.....**
   
   All this is for the one line of log in 
https://github.com/apache/hive/blob/cbd6363ce904ea9150a8e8591d60edfc6b4adea9/serde/src/java/org/apache/hadoop/hive/serde2/AbstractSerDe.java#L93
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to