scarlin-cloudera commented on code in PR #4442:
URL: https://github.com/apache/hive/pull/4442#discussion_r1330130220


##########
ql/src/test/results/clientpositive/tez/tez_union_udtf.q.out:
##########
@@ -140,7 +137,7 @@ POSTHOOK: Input: default@src
 POSTHOOK: Input: default@src1
 POSTHOOK: Output: database:default
 POSTHOOK: Output: default@x
-POSTHOOK: Lineage: x.key EXPRESSION [(src)src.FieldSchema(name:key, 
type:string, comment:default), (src1)src1.FieldSchema(name:key, type:string, 
comment:default), ]

Review Comment:
   Upon debugging this, I noticed that the information is getting lost because 
the column is "key" and there is a filter that makes sure that key is always 
"238".  
   
   The change of making this run through CBO is changing the operator so that 
the expression within the select operator is now "238" instead of key, so 
that's why the information is getting lost.
   
   This seems to be slightly inconsistent on the lateral view side which also 
has the same filter.
   
   Having said all that, it doesn't look like this issue is related to this 
change, other than changing to CBO.  I'm not sure what the correct lineage is 
here, since the column will always be a constant.  But this issue is not 
specific to this patch, so I think we should push ahead with the patch anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to