nrg4878 commented on code in PR #4141:
URL: https://github.com/apache/hive/pull/4141#discussion_r1343158023


##########
standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql:
##########
@@ -101,7 +101,7 @@ CREATE TABLE PART_COL_STATS
 
 ALTER TABLE PART_COL_STATS ADD CONSTRAINT PART_COL_STATS_PK PRIMARY KEY 
(CS_ID);
 
-CREATE INDEX PCS_STATS_IDX ON PART_COL_STATS (CAT_NAME, 
DB_NAME,TABLE_NAME,COLUMN_NAME,PARTITION_NAME);
+CREATE INDEX PCS_STATS_IDX ON PART_COL_STATS 
(DB_NAME,TABLE_NAME,COLUMN_NAME,PARTITION_NAME, CAT_NAME);

Review Comment:
   @rahulchugh We would like to understand this guidance a bit better. We can 
understand how columns with high cardinality have better read performance but 
we are not sure if this would have regressed write performance or at the least 
have bloated size on storage.  
   Can you please point us to some docs/best practices guide on this 
recommendation? Or if you are familiar with how such indices are stored, could 
you please educate us? Thank you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to