mdayakar commented on code in PR #4760:
URL: https://github.com/apache/hive/pull/4760#discussion_r1343797487
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java:
##########
@@ -74,25 +77,40 @@
import com.google.common.base.Joiner;
public class MetaStoreUtils {
- /** A fixed date format to be used for hive partition column values. */
- public static final ThreadLocal<DateFormat> PARTITION_DATE_FORMAT =
- new ThreadLocal<DateFormat>() {
- @Override
- protected DateFormat initialValue() {
- DateFormat val = new SimpleDateFormat("yyyy-MM-dd");
- val.setLenient(false); // Without this, 2020-20-20 becomes 2021-08-20.
- val.setTimeZone(TimeZone.getTimeZone("UTC"));
- return val;
- }
- };
- public static final ThreadLocal<DateTimeFormatter>
PARTITION_TIMESTAMP_FORMAT =
- new ThreadLocal<DateTimeFormatter>() {
- @Override
- protected DateTimeFormatter initialValue() {
- return DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss").
- withZone(TimeZone.getTimeZone("UTC").toZoneId());
- }
- };
+
+ private static final DateTimeFormatter DATE_FORMATTER =
createDateTimeFormatter("uuuu-MM-dd");
+
+ private static final DateTimeFormatter TIMESTAMP_FORMATTER =
createDateTimeFormatter("uuuu-MM-dd HH:mm:ss");
+
+ private static DateTimeFormatter createDateTimeFormatter(String format) {
+ return DateTimeFormatter.ofPattern(format)
+ .withZone(TimeZone.getTimeZone("UTC").toZoneId())
+ .withResolverStyle(ResolverStyle.STRICT);
+ }
+
+ /**
+ * Converts java.sql.Date to String format.
+ * @param date - java.sql.Date object.
+ * @return Date in string format.
+ */
+ public static String convertDateToString(Date date) {
+ return DATE_FORMATTER.format(date.toLocalDate());
+ }
+
+ public static Date convertStringToDate(String date) {
+ LocalDate val = LocalDate.parse(date, DATE_FORMATTER);
+ return java.sql.Date.valueOf(val);
+ }
+
+ public static String convertTimestampToString(Timestamp timestamp) {
+ return TIMESTAMP_FORMATTER.format(timestamp.toLocalDateTime());
+ }
+
+ public static Timestamp convertStringToTimestamp(String timestamp) {
+ LocalDateTime val =
LocalDateTime.from(TIMESTAMP_FORMATTER.parse(timestamp));
+ return Timestamp.valueOf(val);
+ }
+
Review Comment:
Modified `PartFilterVisitor` to use `MetaStoreUtils` APIs. Now both
`PartFilterVisitor` and `MetaStoreDirectSql` are using same APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
