mayankkunwar commented on code in PR #4758:
URL: https://github.com/apache/hive/pull/4758#discussion_r1345716822
##########
common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java:
##########
@@ -95,6 +95,9 @@ public void testConfProperties() throws Exception {
// Test HiveConf property variable substitution in hive-site.xml
checkHiveConf("test.var.hiveconf.property",
ConfVars.DEFAULTPARTITIONNAME.getDefaultValue());
+
+ // Test if LLAP_LRFU_HOTBUFFERS_PERCENTAGE is defined in HiveConf
+
Assert.assertTrue(HiveConf.getLlapDaemonConfVars().contains(ConfVars.LLAP_LRFU_HOTBUFFERS_PERCENTAGE.varname));
Review Comment:
How about, if I add some comment in ConfVars description that "This is the
part of LLAP Daemon" and then I can filter those confs for testing.
But the thing is, in future when someone adds new LLAP daemon conf var, they
should add this comment in the description i.e. "This is the part of LLAP
Daemon".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
