SourabhBadhya commented on code in PR #4748:
URL: https://github.com/apache/hive/pull/4748#discussion_r1349884129
##########
ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java:
##########
@@ -552,6 +564,10 @@ private static SearchArgument
getSearchArgumentFromExpression(Configuration conf
}
}
+ public static boolean isCompleteConversion(Configuration conf,
ExprNodeGenericFuncDesc expression) {
Review Comment:
Added asserts to existing tests in TestConvertAstToSearchArg for each unit
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
