deniskuzZ commented on code in PR #4776:
URL: https://github.com/apache/hive/pull/4776#discussion_r1349969879
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -846,6 +849,23 @@ private void expireSnapshot(Table icebergTable,
AlterTableExecuteSpec.ExpireSnap
}
}
+ private void expireSnapshotByTimestampRange(Table icebergTable, Long
fromTimestamp, Long toTimestamp,
+ ExecutorService deleteExecutorService) {
+ ExpireSnapshots expireSnapshots = icebergTable.expireSnapshots();
+ for (Snapshot snapshot : icebergTable.snapshots()) {
Review Comment:
do we know if snapshot array is sorted by timestamp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
