zabetak commented on PR #4754: URL: https://github.com/apache/hive/pull/4754#issuecomment-1752964093
> Changes look good to me. The only concern is do we need to run this test against multiple dbs every time? Indeed the tests are somewhat lengthy when using the docker containers. I am fine to let's say run them only for one but I am afraid they will be broken quite soon. It would be nice if we can find a way to keep them active and functional. One option to reduce the duration and still have regular coverage is to run them for only one DB but in a randomized manner. For instance, MySQL runs on Monday, Derby runs on Tuesday, MSSQL runs on Wednesday, etc., or something along these lines. Another idea would be to run them all but only once daily. This probably would require setting more CI jobs etc., but it is still an option. I am also open to other ideas and suggestions if any. > we also automatically trigger a Metastore initialization against these DBMS in Jenkins build, is there a chance to move the SchemaTool validation to the same place? This is would be a completely different PR since there is no something that we could use from here. Going into this direction would probably be a PR for https://github.com/kgyrtkirk/hive-dev-box not for Hive. Note that under `DbInstallBase` we already have default installation and validation for most supported DBMS. These tests however, do not check what happens when there are errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
