zhangbutao commented on code in PR #4781:
URL: https://github.com/apache/hive/pull/4781#discussion_r1351933080
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1590,10 +1593,18 @@ public Map<String, String>
getNativeProperties(org.apache.hadoop.hive.ql.metadat
public boolean shouldOverwrite(org.apache.hadoop.hive.ql.metadata.Table
mTable, String operationName) {
String mode = null;
String formatVersion =
mTable.getTTable().getParameters().get(TableProperties.FORMAT_VERSION);
- // As of now only delete mode is supported, for all others return false
- if ("2".equals(formatVersion) &&
operationName.equalsIgnoreCase(Context.Operation.DELETE.toString())) {
- mode = mTable.getTTable().getParameters()
- .getOrDefault(TableProperties.DELETE_MODE,
TableProperties.DELETE_MODE_DEFAULT);
+ // As of now only update & delete modes are supported, for all others
return false
+ if ("2".equals(formatVersion)) {
Review Comment:
Acutually, both V1 and V2 support copy on write. The current qtests are
all limited to v2 iceberg tables. Maybe we can fix this after all the COW
modes(merge/update/delete) are supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
