simhadri-g commented on code in PR #4761:
URL: https://github.com/apache/hive/pull/4761#discussion_r1356525159
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -488,6 +490,9 @@ private void commitWrite(Table table, String branchName,
Long snapshotId, long s
if (snapshotId != null) {
write.validateFromSnapshot(snapshotId);
}
+ Expression conflictDetectionFilter =
Expressions.and(Expressions.alwaysTrue(), filterExpr);
Review Comment:
Incase there are no filters in the query, we will have to pass true to the
conflict detection filter. For this case the Expressions.alwaysTrue(),
filterExpr) is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
