zhangbutao commented on code in PR #4786:
URL: https://github.com/apache/hive/pull/4786#discussion_r1359861127
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java:
##########
@@ -514,6 +514,21 @@ public void apply(SerDeInfo t, Object[] fields) {
}
}
+ static void setFunctionResourceUris(String FUNC_RU, PersistenceManager pm,
String funcIds,
+ TreeMap<Long, Function> functions)
+ throws MetaException {
+ String queryText;
+ queryText = "select \"FUNC_ID\", \"RESOURCE_TYPE\", \"RESOURCE_URI\" from
" + FUNC_RU + ""
Review Comment:
My bad. Fixed. Thanks.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -11579,6 +11579,33 @@ public Function getFunction(String catName, String
dbName, String funcName) thro
@Override
public List<Function> getAllFunctions(String catName) throws MetaException {
+ try {
+ return getFunctionsInternal(catName);
+ } catch (NoSuchObjectException e) {
+ throw new RuntimeException(e);
+ }
+ }
+
+ protected List<Function> getFunctionsInternal(String catalogName)
+ throws MetaException, NoSuchObjectException {
+ return new GetListHelper<Function>(catalogName, "", "", true, true) {
+ @Override
+ protected List<Function> getSqlResult(GetHelper<List<Function>> ctx)
throws MetaException {
+ return directSql.getFunctions(catalogName);
+ }
+ @Override
+ protected List<Function> getJdoResult(GetHelper<List<Function>> ctx)
throws MetaException {
+ try {
+ return getAllFunctionsViaJDO(catalogName);
+ } catch (Exception e) {
+ LOG.error("Failed to convert to funcs", e);
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
