wypoon commented on code in PR #4793:
URL: https://github.com/apache/hive/pull/4793#discussion_r1364032157
##########
iceberg/iceberg-catalog/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##########
@@ -531,7 +531,6 @@ public void testEngineHiveEnabledConfig() throws TException
{
catalog.dropTable(TABLE_IDENTIFIER);
// Enable by hive-conf
- catalog.getConf().set(ConfigProperties.ENGINE_HIVE_ENABLED, "true");
Review Comment:
This line should have been kept, as it exercises a code path that still
exists.
As it is, `hiveEngineEnabled` still returns true but via a different code
path, and the preceding comment is misleading.
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -552,8 +552,7 @@ private static boolean hiveEngineEnabled(TableMetadata
metadata, Configuration c
return metadata.propertyAsBoolean(TableProperties.ENGINE_HIVE_ENABLED,
false);
}
- return conf.getBoolean(
- ConfigProperties.ENGINE_HIVE_ENABLED,
TableProperties.ENGINE_HIVE_ENABLED_DEFAULT);
+ return conf.getBoolean(ConfigProperties.ENGINE_HIVE_ENABLED, true);
Review Comment:
Please update the javadoc comment for this static method.
```
* <li>If none of the above is enabled then use the default value {@link
TableProperties#ENGINE_HIVE_ENABLED_DEFAULT}
```
should be
```
* <li>If none of the above is enabled then use true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
