dengzhhu653 commented on code in PR #4726:
URL: https://github.com/apache/hive/pull/4726#discussion_r1367581907
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -2188,12 +2186,12 @@ public List<Partition> listPartitions(String catName,
String db_name, String tbl
if (db_name == null || tbl_name == null) {
throw new MetaException("Database name/Table name should not be null");
}
- boolean skipColumnSchemaForPartition = MetastoreConf.getBoolVar(conf,
ConfVars.METASTORE_CLIENT_FIELD_SCHEMA_FOR_PARTITIONS);
Review Comment:
For `add_partitions`, it would be a bit confusing as the partitions returned
from HMS are different from the partitions to be added, e.g, miss some
partition parameters.
For `drop_partitions`, it's debatable, as the PR mainly focuses on the Get
operations, what do you think of?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
