niteshy commented on code in PR #4755:
URL: https://github.com/apache/hive/pull/4755#discussion_r1369069958


##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2782,6 +2782,12 @@ public static enum ConfVars {
         new StringSet("kll"),
         "Defines which sketch type to use when rewriting RANK expressions. 
Options: kll"),
 
+    //Compile summary
+    HIVE_COMPILE_SUMMARY(
+        "hive.compile.print.summary",

Review Comment:
   Do we need this in the documentation? 



##########
common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java:
##########
@@ -93,6 +95,24 @@ public class PerfLogger {
   protected final Map<String, Long> startTimes = new ConcurrentHashMap<>();
   protected final Map<String, Long> endTimes = new ConcurrentHashMap<>();
 
+  public static class QueryStep {

Review Comment:
   can you explain the QueryStep (maybe add the Java doc for the class) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to