ayushtkn commented on code in PR #4841:
URL: https://github.com/apache/hive/pull/4841#discussion_r1378586705
##########
shims/common/src/main/java/org/apache/hadoop/hive/shims/Utils.java:
##########
@@ -172,6 +173,10 @@ public static boolean
checkFileSystemXAttrSupport(FileSystem fs) throws IOExcept
LOG.warn("XAttr won't be preserved since it is not supported for file
system: " + fs.getUri());
return false;
}
+ catch (AccessControlException e) {
+ LOG.warn(e.getMessage());
+ return false;
+ }
Review Comment:
it won't fail, it won't preserve xAttr and replication will go on with
DistCp not preserving xAttr, this method was added to check if the FS supports
xAttrs or not, if it does support, the xAttrs were always preserved.
The FileSystem description of getXAttr
```
* @throws UnsupportedOperationException if the operation is unsupported
* (default outcome).
*/
public byte[] getXAttr(Path path, String name) throws IOException {
```
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java#L3280-L3283
So, Ideally every HCFS should abide by this, so ignoring ACE ain't an option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
