hzxiongyinke commented on code in PR #4821:
URL: https://github.com/apache/hive/pull/4821#discussion_r1378695468
##########
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java:
##########
@@ -731,6 +734,24 @@ private static void start(SessionState startSs, boolean
isAsync, LogHelper conso
// that would cause ClassNoFoundException otherwise
throw new RuntimeException(e);
}
+ try {
+ if(!startSs.isHiveServerQuery){
Review Comment:
> A lot of nested if conditionals. Can we move this inside a method and
probably invert the if conditions so that if those are satisfied then return.
Something like -
>
> ```
> void methodName() {
> if (startSs.isHiveServerQuery) {
> return;
> }
> if
(!getSessionConf().getBoolVar(ConfVars.METASTORE_USE_THRIFT_SASL) {
> return;
> }
> ...... (so on)
> }
> ```
Looks good, I will do it this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
