kasakrisz commented on code in PR #4779: URL: https://github.com/apache/hive/pull/4779#discussion_r1384623974
########## ql/src/java/org/apache/hadoop/hive/ql/exec/DDLPlanUtils.java: ########## @@ -271,9 +273,9 @@ public String getPartitionActualName(Partition pt) { for (String partCol : partColsDef) { String[] colValue = partCol.split("="); if (colTypeMap.get(colValue[0]).equalsIgnoreCase("string")) { Review Comment: This is about partition key values not identifiers. Please create another jira to track this because AFAIK not only string type should be quoted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org