zhangbutao commented on code in PR #4871:
URL: https://github.com/apache/hive/pull/4871#discussion_r1391157659
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -593,6 +594,9 @@ private Path getColStatsPath(Table table) {
}
private Path getColStatsPath(Table table, long snapshotId) {
+ if (((BaseTable) table).operations() instanceof HadoopTableOperations) {
+ return new Path(table.location() + STATS + snapshotId);
Review Comment:
We don't need table name in stats file as the parent path already has table
name which can be used to identify the specific table.
Use the `snap` as prefix is reasonable for me. And i think there is no
compatibility issues if changing the hive-catalog colpath to keep the same path
format as HadopTable. Changed in
https://github.com/apache/hive/pull/4871/commits/b1ffb414699b1cf6778b10b7f74bbbdc02a5d6cd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
