kasakrisz commented on code in PR #4832:
URL: https://github.com/apache/hive/pull/4832#discussion_r1393797125
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -723,11 +588,88 @@ private String getPredicate() {
@Override
protected boolean allowOutputMultipleTimes() {
- return conf.getBoolVar(HiveConf.ConfVars.SPLIT_UPDATE) ||
conf.getBoolVar(HiveConf.ConfVars.MERGE_SPLIT_UPDATE);
+ return conf.getBoolVar(HiveConf.ConfVars.SPLIT_UPDATE);
}
@Override
protected boolean enableColumnStatsCollecting() {
return numWhenMatchedUpdateClauses == 0 && numWhenMatchedDeleteClauses ==
0;
}
+
+ /**
+ * This allows us to take an arbitrary ASTNode and turn it back into SQL
that produced it.
+ * Since HiveLexer.g is written such that it strips away any ` (back ticks)
around
+ * quoted identifiers we need to add those back to generated SQL.
+ * Additionally, the parser only produces tokens of type Identifier and never
+ * QuotedIdentifier (HIVE-6013). So here we just quote all identifiers.
+ * (') around String literals are retained w/o issues
+ */
+ private static class IdentifierQuoter {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
