zhangbutao commented on code in PR #4855:
URL: https://github.com/apache/hive/pull/4855#discussion_r1395291536
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java:
##########
@@ -235,6 +235,10 @@ public static boolean isIcebergTable(Table table) {
table.getStorageHandler().getType() == StorageHandlerTypes.ICEBERG;
}
+ public static boolean
isIcebergTable(org.apache.hadoop.hive.metastore.api.Table table) {
+ return
table.getParameters().get(HiveMetaHook.TABLE_TYPE).equals(HiveMetaHook.ICEBERG);
Review Comment:
To avoid NPE:
```suggestion
return
HiveMetaHook.ICEBERG.equals(table.getParameters().get(HiveMetaHook.TABLE_TYPE));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
