abstractdog commented on PR #4874: URL: https://github.com/apache/hive/pull/4874#issuecomment-1813983108
> There is a comment here: https://issues.apache.org/jira/browse/HIVE-27871?focusedCommentId=17785948&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17785948 > > It is not addressed here, we should handle all the logger lines in this file. > > On a side note: I am not sure about this coding practice, why someone needs to define these constants, could have directly used the already defined ones `RM_WEBAPP_ADDRESS` and so, anyway.... I agree with @ayushtkn, these static constants make sense if you use it 10-20 times in a class, but that's not the case here, I would simply purge them them and use directly YarnConfiguration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
