kasakrisz commented on code in PR #4869:
URL: https://github.com/apache/hive/pull/4869#discussion_r1395700949
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveAugmentSnapshotMaterializationRule.java:
##########
@@ -125,11 +131,12 @@ public void onMatch(RelOptRuleCall call) {
Table table = hiveTable.getHiveTableMD();
SnapshotContext mvMetaTableSnapshot =
mvMetaStoredSnapshot.get(table.getFullyQualifiedName());
- if
(mvMetaTableSnapshot.equals(table.getStorageHandler().getCurrentSnapshotContext(table)))
{
+ if (Objects.equals(mvMetaTableSnapshot,
table.getStorageHandler().getCurrentSnapshotContext(table))) {
Review Comment:
Added null check.
In theory this can not happen because this rule is used only if MV base
tables are Iceberg. Mixed mode is not supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
