abstractdog commented on code in PR #4683:
URL: https://github.com/apache/hive/pull/4683#discussion_r1396210381
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java:
##########
@@ -101,8 +101,11 @@ public void checkQueueAccess(
checkQueueAccessInternal(queueName, userName);
return null;
});
- } catch (Exception exception) {
+ } catch (InterruptedException exception) {
+ // we need to catch only IO exception/Interrupted Exception here,
Review Comment:
okay, I'm fine with the patch now, my point was whether we can write UT that
shows this regression, like below, but you can do it in a follow-up ticket if
you're interested
```
YarnQueueHelper helper = spy(new YarnQueueHelper(new HiveConf()));
doThrow(HiveException.class).when(helper).checkQueueAccessInternal(anyString(),
anyString());
try {
helper.checkQueueAccess("fake", "fake");
Assert.fail("HiveException is supposed to be thrown");
} catch (Exception e) {
Assert.assertEquals(HiveException.class, e.getCause().getClass());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
