zhangbutao commented on PR #4852: URL: https://github.com/apache/hive/pull/4852#issuecomment-1820459467
> @zhangbutao, could you please check if I haven't messed up the input params in `TestHiveIceberg*` tests you created (branch, tag, etc). tried to remove redundant combinations in some of them, however, I think we still have many of those remaining Hi @deniskuzZ , I am ok with your current change. IMO, branch&tag&snapshot related tests are mostly DDL tasks, so it is safe to be tested by one time (HiveCatalog, Parquet, V1), and the test times can be reduced from 9 time to 1 time. For other tests i also think it should be ok as I often see the Apache Iceberg souce code tested with just one catalog. We can think more how to find a best way to optimize all tests in the future work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
