difin commented on code in PR #4855:
URL: https://github.com/apache/hive/pull/4855#discussion_r1405257860
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -437,6 +441,9 @@ private void commitTable(FileIO io, ExecutorService
executor, OutputTable output
dataFiles.addAll(writeResults.dataFiles());
deleteFiles.addAll(writeResults.deleteFiles());
referencedDataFiles.addAll(writeResults.referencedDataFiles());
+ rewritePolicy = rewritePolicy == RewritePolicy.DEFAULT ?
Review Comment:
Because this assignment is happening inside the loop which iterates over the
list of job contexts.
I am assigning the rewrite policy in case it is still default (unset)
because if there are >1 job contex, it's unknown which one of them will contain
the rewrite policy config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
