chenruotao commented on code in PR #4854:
URL: https://github.com/apache/hive/pull/4854#discussion_r1410700755
##########
ql/src/java/org/apache/hadoop/hive/ql/DriverState.java:
##########
@@ -89,7 +89,11 @@ public void compiling() {
public void compilingWithLocking() {
lock();
try {
- driverState = State.COMPILING;
+ if (isDestroyed() || isClosed()) {
+ abort();
Review Comment:
yes, but the question is that the driver may be set null when the query is
in the middle of compilation, and if the compiling thread just runs before
lock(), the driverState will be reset to State.COMPILING from State.CLOSED OR
State.DESTROYED, and keep running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
