dengzhhu653 commented on code in PR #4820:
URL: https://github.com/apache/hive/pull/4820#discussion_r1411749568


##########
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java:
##########
@@ -481,6 +482,25 @@ public void onAlterPartition(AlterPartitionEvent 
partitionEvent) throws MetaExce
     process(event, partitionEvent);
   }
 
+  @Override
+  public void onAlterPartitions(AlterPartitionsEvent event) throws 
MetaException {
+    Table table = event.getTable();
+    Iterator<List<Partition>> iterator = 
event.getNewPartsIterator(maxBatchSize);

Review Comment:
   > The JDBC max batch size may not be equal to Thrift max message size. So 
the consumers of these events may get thrift max message limit error if stats 
are stored in each of these partitions.
   
   Right, and I don't want to introduce a new property for the batch size. An 
idea is try to exclude the stats from the message, but I'm not sure if it will 
hurt the query performance for downstream project using the serialized 
partitions(without stats), they need to recompute/refetch the stats again



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to