difin commented on PR #4855: URL: https://github.com/apache/hive/pull/4855#issuecomment-1837027378
> @difin, are we using ACID thresholds to schedule the compaction, Worker#isEnoughToCompact? Not even sure if that lists the proper data dir. Also, after the successful compaction, do we mark the entry as "ready for cleaning" or move it into the "COMPLETED_COMPACTIONS", CompactionTxnHandler#markCleaned? I implemented a strategy design pattern in the main routine of the compaction worker to have different behavior of the worker for different tables types. Also, I added `show compactions ` command to the new q-tests to test that iceberg compactions get to completed stage now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
