deniskuzZ commented on code in PR #4908:
URL: https://github.com/apache/hive/pull/4908#discussion_r1413881798
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -732,6 +809,16 @@ private void addCustomSortExpr(Table table,
org.apache.hadoop.hive.ql.metadata.
int order = fieldOrderMap.get(spec.getColumnName());
if (TransformSpec.TransformType.BUCKET.equals(spec.getTransformType())) {
customSortExprs.add(BUCKET_SORT_EXPR.apply(order + offset,
spec.getTransformParam().get()));
+ } else if
(TransformSpec.TransformType.TRUNCATE.equals(spec.getTransformType())) {
Review Comment:
@SourabhBadhya, could we move that switch logic into
`IcebergTransformSortFunctions`? see above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
