deniskuzZ commented on code in PR #4566:
URL: https://github.com/apache/hive/pull/4566#discussion_r1419107740
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -248,199 +182,141 @@
* the metstore call stack should have logic not to retry. There are {@link
RetrySemantics}
* annotations to document the behavior.
*/
+@SuppressWarnings("SqlSourceToSinkFlow")
@InterfaceAudience.Private
@InterfaceStability.Evolving
-abstract class TxnHandler implements TxnStore, TxnStore.MutexAPI {
+public abstract class TxnHandler implements TxnStore, TxnStore.MutexAPI {
+
- private static final String TXN_TMP_STATE = "_";
- private static final String DEFAULT_POOL_NAME = "default";
+ public static class TxnHandlingFeatures {
Review Comment:
please rename to ConfVars.
````
private static final ConfVars vars;
vars = new ConfVars(table->checkIfTableIsUsable(table), conf)
public static final ConfVars {
private boolean useMinHistoryLevel;
private boolean useMinHistoryWriteId;
public ConfVars(Predicate<String> tableCheck, Conf conf){
useMinHistoryLevel = tableCheck.test("MIN_HISTORY_WRITE_ID",
MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.TXN_USE_MIN_HISTORY_WRITE_ID))
}
}
````
TxnHandler.getConfVars().useMinHistoryWriteId
TxnHandler.getConfVar().useMinHistoryLevel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
