abstractdog commented on code in PR #4920:
URL: https://github.com/apache/hive/pull/4920#discussion_r1424227058
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java:
##########
@@ -716,19 +718,18 @@ private static String getContainerJavaOpts(Configuration
conf) {
}
logLevel = sb.toString();
+ String finalOpts = null;
if (HiveConf.getIntVar(conf, HiveConf.ConfVars.HIVETEZCONTAINERSIZE) > 0) {
- if (javaOpts != null) {
- return javaOpts + " " + logLevel;
- } else {
- return logLevel;
- }
+ finalOpts = javaOpts != null ? javaOpts + " " + logLevel : logLevel;
} else {
if (javaOpts != null && !javaOpts.isEmpty()) {
LOG.warn(HiveConf.ConfVars.HIVETEZJAVAOPTS + " will be ignored because
"
- + HiveConf.ConfVars.HIVETEZCONTAINERSIZE + " is not set!");
+ + HiveConf.ConfVars.HIVETEZCONTAINERSIZE + " is not set!");
}
- return logLevel + " " + MRHelpers.getJavaOptsForMRMapper(conf);
+ finalOpts = logLevel + " " + MRHelpers.getJavaOptsForMRMapper(conf);
}
+ LOG.debug("Tez container log level: '{}', java opts: '{}', final opts:
{}", logLevel, javaOpts, finalOpts);
Review Comment:
final opts is a result of some minor magic here above, so if it's not
obvious why it is what it is, the values of the passed-in logLevel and javaOpts
variables might help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
