deniskuzZ commented on code in PR #4761:
URL: https://github.com/apache/hive/pull/4761#discussion_r1425472876
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -591,4 +596,19 @@ HiveLock lockObject(TableMetadata metadata) {
return new NoLock();
}
}
+
+ /**
+ * Checks if the storage_handler property is already set to
HIVE_ICEBERG_STORAGE_HANDLER.
+ * @param storageHandler Storage Handler class
+ * @return true if the storage_handler property is set to
HIVE_ICEBERG_STORAGE_HANDLER
+ */
+ private static boolean isHiveIcebergStorageHandler(String storageHandler) {
+ try {
+ Class<?> storageHandlerClass = Class.forName(storageHandler);
+ Class<?> icebergStorageHandlerClass =
Class.forName(HIVE_ICEBERG_STORAGE_HANDLER);
+ return icebergStorageHandlerClass.isAssignableFrom(storageHandlerClass);
Review Comment:
````
HiveIcebergStorageHandler.class.isAssignableFrom(Class.forName(storageHandler))
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
