BsoBird commented on PR #4946: URL: https://github.com/apache/hive/pull/4946#issuecomment-1856084148
@zhangbutao Hi. butao. I read the code for HIVE-16079, and I think that we can use non-static caching without re-triggering the OOM problem. This is because HIVE-16079 handles this by INTERNER all strings and properties objects. For example, CopyOnFirstWriteProperties::INTERNER. Since we already have a static cache based on the JVM, I don't think it's necessary to set SplitGroup.cache[] to be static, given the scenario in which LLAP works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
