deniskuzZ commented on code in PR #4902: URL: https://github.com/apache/hive/pull/4902#discussion_r1428820807
########## jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java: ########## @@ -30,6 +30,8 @@ * */ public class HiveResultSetMetaData implements java.sql.ResultSetMetaData { + private static final String DOT = "."; Review Comment: all constants should be marked as `static final` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org