deniskuzZ commented on code in PR #4945:
URL: https://github.com/apache/hive/pull/4945#discussion_r1430010003
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -2014,4 +2014,9 @@ public List<Partition>
getPartitionsByExpr(org.apache.hadoop.hive.ql.metadata.Ta
throw new SemanticException(String.format("Error while fetching the
partitions due to: %s", e));
}
}
+
+ @Override
+ public boolean requiresLocationAtCreateTable() {
Review Comment:
maybe similar to
````
default void
setTableParametersForCTLT(org.apache.hadoop.hive.ql.metadata.Table tbl,
CreateTableLikeDesc desc,
Map<String, String> origParams) {
}
````
setTableLocationForCTAS(CreateTableDesc desc, Supplier\<String\> location)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
