wecharyu commented on code in PR #4744:
URL: https://github.com/apache/hive/pull/4744#discussion_r1430401364
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java:
##########
@@ -217,9 +216,7 @@ private void getColumnDataColPathSpecified(Table table,
Partition part, List<Fie
}
} else {
List<String> partitions = new ArrayList<String>();
- // The partition name is converted to lowercase before generating the
stats. So we should use the same
- // lower case name to get the stats.
- String partName = HMSHandler.lowerCaseConvertPartName(part.getName());
+ String partName = part.getName();
Review Comment:
The `lowerCaseConvertPartName` is only used in partition stats related APIs.
I think it's OK to remove it, because most of APIs such as
`HMSHandler#get_partitions_by_names` related to partition names do not contain
such behavior.
In other words, HMS requires that user should input the correct partition
names to get the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
