zabetak commented on code in PR #4951:
URL: https://github.com/apache/hive/pull/4951#discussion_r1434973891
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -15930,18 +15932,14 @@ public ColsAndTypes(String cols, String colTypes) {
public String colTypes;
}
- public String getInvalidAutomaticRewritingMaterializationReason() {
- return invalidAutomaticRewritingMaterializationReason;
- }
-
- public void setInvalidAutomaticRewritingMaterializationReason(
- String invalidAutomaticRewritingMaterializationReason) {
- this.invalidAutomaticRewritingMaterializationReason =
- invalidAutomaticRewritingMaterializationReason;
+ public MaterializationValidationResult
getAutomaticRewritingValidationResult() {
+ return materializationValidationResult;
}
- public boolean isValidAutomaticRewritingMaterialization() {
- return (invalidAutomaticRewritingMaterializationReason == null);
+ public void setAutomaticRewritingValidationResult(
+ MaterializationValidationResult materializationValidationResult) {
+ this.materializationValidationResult =
+ materializationValidationResult;
Review Comment:
nit: Since we dropped "Automatic" from the result we can as well drop it
from the methods since we are renaming them anyways.
Feel free to disregard or address directly during merge without waiting for
a new CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
