BsoBird commented on PR #4946: URL: https://github.com/apache/hive/pull/4946#issuecomment-1868438977
> in the whole project there is just single test that uses that cache and not from `HiveSplitGenerator` https://github.com/apache/hive/pull/4969/files http://ci.hive.apache.org/job/hive-precommit/job/PR-4969/1/ > > mvn test -Dtest=TestHiveFileFormatUtils#testGetPartitionDescFromPathRecursively > > we should add the q test that would trigger that part of code > > @BsoBird I think it's ok to remove `static` since this cache has static modifier only because the original signature of `generateGroupedSplits` (before [HIVE-8409](https://issues.apache.org/jira/browse/HIVE-8409) refactor) was also static. Also no need for ConcurrentHashMap in that case. > > ``` > public static Multimap<Integer, InputSplit> generateGroupedSplits > ``` So, are we going to go with the first version of the programme? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
