dengzhhu653 commented on code in PR #4995:
URL: https://github.com/apache/hive/pull/4995#discussion_r1449682067
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -181,7 +182,7 @@ private void populateInsertUpdateMap(Map<PartitionInfo,
ColumnStatistics> statsP
e -> e.partitionId).collect(Collectors.toList()
);
- prefix.append("select \"PART_ID\", \"COLUMN_NAME\" from \"PART_COL_STATS\"
WHERE ");
+ prefix.append("select \"PART_ID\", \"COLUMN_NAME\", \"ENGINE\" from
\"PART_COL_STATS\" WHERE ");
Review Comment:
Morning @zhangbutao!
In this method we want to get the insert or the update statistics from
`Map<PartitionInfo, ColumnStatistics> statsPartInfoMap`, there is no guarantee
that all of the `statsPartInfoMap` are for the engine hive or the same engine,
so PartColNameInfo needs to feed with the engine info when compared with the
stats in `statsPartInfoMap`.
> BTW, we also have another field CAT_NAME in PART_COL_STATS to
differentiate column stas between multi catalog. Should we also consider it
here?
I think we don't need to, the `PART_ID` here has the same effect for
clarifying the catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
