kasakrisz commented on code in PR #4990:
URL: https://github.com/apache/hive/pull/4990#discussion_r1451875835
##########
hplsql/src/main/java/org/apache/hive/hplsql/objects/TableClass.java:
##########
@@ -96,9 +96,9 @@ public class TableClass implements HplClass {
} else { // single column
Row row = new Row();
row.addColumn(
- self.hplClass().columns().get(0).columnName(),
- self.hplClass().columns.get(0).columnTypeString(),
- args.get(1));
Review Comment:
Seems to be an unrelated change.
##########
itests/hive-unit/pom.xml:
##########
@@ -494,6 +494,12 @@
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>net.sf.supercsv</groupId>
+ <artifactId>super-csv</artifactId>
+ <version>${super-csv.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Is this a necessary change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
