zhangbutao commented on code in PR #4999:
URL: https://github.com/apache/hive/pull/4999#discussion_r1452323394
##########
storage-api/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestStringExpr.java:
##########
@@ -20,6 +20,7 @@
import org.junit.Test;
+import java.io.ByteArrayOutputStream;
import java.nio.charset.StandardCharsets;
import static org.junit.Assert.*;
Review Comment:
Can you help to fix the wildcard * import as well?
##########
ql/src/test/queries/clientpositive/like_control_characters.q:
##########
@@ -0,0 +1,15 @@
+set hive.mapred.mode=nonstrict;
+set hive.explain.user=false;
+set hive.vectorized.execution.enabled=true;
+
+create temporary table foo (col string) stored as orc;
+create temporary table bar (col binary) stored as orc;
+
+-- SORT_QUERY_RESULTS
+
+INSERT INTO bar select unhex('6162636465-166676869');
Review Comment:
Maybe just a question: can we use other way instead of the udf `unhex` to
insert the control characters?
I want to keep the qtest more lightweight and independent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
