tc-gaoxiong commented on code in PR #4981: URL: https://github.com/apache/hive/pull/4981#discussion_r1453006203
########## ql/src/test/queries/clientpositive/ptf_register_use_2.q: ########## @@ -0,0 +1,2 @@ +-- session 2: use function Review Comment: Thanks for your review! As you suggest, this pr should add `data/files/datasets/temp_udaf/load.hive.sql` file to create function, and a `ptf_register_use.q` file to invoke function. I test it local. By log, hive does use two session to exeuct create an invoke. ```txt 2024-01-15T22:45:28,041 INFO [main] SessionState: Hive Session ID = bbc2a0ea-227a-4c07-a7a6-52c3a50e1e06 ... 2024-01-15T22:45:29,451 INFO [main] SessionState: Hive Session ID = e8ffa509-9272-483b-a885-ef7d92e705cd ``` Also, the create does execute before invoke : https://github.com/apache/hive/blob/06ef7c8231501c0314875d640f081adc35a70db6/itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCliDriver.java#L112-L115 So, are we agreed on the idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
