deniskuzZ commented on code in PR #4959:
URL: https://github.com/apache/hive/pull/4959#discussion_r1462837269
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java:
##########
@@ -749,6 +753,22 @@ public Object getBoolean(boolean val) {
return val;
}
+ public Object convertDateValue(Object dateValue) {
Review Comment:
that is a weird signature for a method that is supposed to accept a String
and return String.
also not clear what kind of conversion it's doing: you convert string to
date and back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
