deniskuzZ commented on code in PR #5003:
URL: https://github.com/apache/hive/pull/5003#discussion_r1466524558
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java:
##########
@@ -776,4 +782,21 @@ public Configuration getConf() {
public void setConf(Configuration c) {
myConf = c;
}
+
+ /**
+ * lockInternal() and {@link #unlockInternal()} are used to serialize those
operations that require
+ * Select ... For Update to sequence operations properly. In practice that
means when running
+ * with Derby database. See more notes at class level.
+ */
+ public void lockInternal() {
+ if(isDERBY()) {
Review Comment:
nit: space
note: SqlRetryHandler has duplicated these methods. Could we please kill the
dups
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java:
##########
@@ -776,4 +782,21 @@ public Configuration getConf() {
public void setConf(Configuration c) {
myConf = c;
}
+
+ /**
+ * lockInternal() and {@link #unlockInternal()} are used to serialize those
operations that require
+ * Select ... For Update to sequence operations properly. In practice that
means when running
+ * with Derby database. See more notes at class level.
+ */
+ public void lockInternal() {
+ if(isDERBY()) {
Review Comment:
nit: space
note: SqlRetryHandler has duplicated these methods. Could we please kill the
dups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
